Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten Electron file #803

Merged
merged 16 commits into from
May 30, 2024
Merged

Flatten Electron file #803

merged 16 commits into from
May 30, 2024

Conversation

garrettmflynn
Copy link
Member

This PR simplifies the Electron-related frontend file. Some conditional statements are still required to handle the test environment for metadata.test.ts.

@garrettmflynn garrettmflynn self-assigned this May 29, 2024
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge May 29, 2024 17:44
@CodyCBakerPhD
Copy link
Collaborator

Huh, surprisingly quite a few errors across various CI despite such a small change

@CodyCBakerPhD CodyCBakerPhD self-requested a review May 29, 2024 19:32
@CodyCBakerPhD CodyCBakerPhD disabled auto-merge May 29, 2024 21:20
@CodyCBakerPhD
Copy link
Collaborator

Chromatic issue on this one

@CodyCBakerPhD
Copy link
Collaborator

Fix to storybook broke dev tests

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge May 30, 2024 16:17
@CodyCBakerPhD CodyCBakerPhD merged commit 8e51691 into main May 30, 2024
20 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the flatten-electron-file branch May 30, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants